Allow to add commands stored in an iterable #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding several commands with a single method call can be really useful,
especially when working with a framework that can detect all commands
instances and inject them in the command bus automatically.
This commit allows commands registration using an iterable, enhancing
the possibilities to — for instance — lazy-load the commands only when
the SDK API is actually called.
Below is an example of how the `Api` class is declared in a recent
Symfony application:
```php
return static function (ContainerConfigurator $container): void {
$container
->services()
// Tagging all commands, so they can be retrieved below
->instanceof(\Telegram\Bot\Commands\CommandInterface::class)
->tag('telegram.command')
// Registering the `Api` class
->set(Api::class)
->args([
'$token' => env('TELEGRAM_BOT_TOKEN')->resolve(),
])
// Adding all commands that were previously tagged
->call('addCommands', [tagged_iterator('telegram.command')]);
};
```
The example above would not work without changing the type of the
parameter, because the `tagged_iterator` is not an array.
|
Interesting change, thanks for the PR. |
|
Hey there, thanks for the merge! I've been waiting for a new release and I noticed the previous one is quite old. Would it be ok to publish a new one? No urge btw, I know that OSS can be very time-consuming. 😉 Thanks for your work on the library! |
|
@romm Thank you for your patience. Before tagging a release, I need to test it with other changes to avoid potential issues for projects that rely on this SDK. Your understanding and patience during this time is appreciated. |
|
Understood! Wishing you the best on the upcoming tests then. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding several commands with a single method call can be really useful, especially when working with a framework that can detect all commands instances and inject them in the command bus automatically.
This commit allows commands registration using an iterable, enhancing the possibilities to — for instance — lazy-load the commands only when the SDK API is actually called.
Below is an example of how the
Apiclass is declared in a recent Symfony application:The example above would not work without changing the type of the parameter, because the
tagged_iteratoris not an array.