Fix PHPDoc: mark optional properties as nullables #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @irazasyed |
|
Thanks. Please consider trying our upcoming V4 (WIP). We don't plan to support this version for long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #962
Goal: help IDE and static analyzers to report about potential null pointer issues.
In this PR I aligned PHPDoc, but it's considered as a bad practice as it produce a lot of noise on git diffs and force developers to align it manually or change IDE setting for this project. I can setup automated coding-style fixer as a new PR (if maintainers likes the idea -- please share your thoughts beforehand).