Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the CHATHISTORY extension specification - refactored #393
Add the CHATHISTORY extension specification - refactored #393
Changes from 1 commit
bbdba28
c633bb7
e7d5def
b0f524f
92b9e20
e1a6b43
3a39a29
950b019
7942807
215b7f5
5d90804
6ede679
e9eb159
0c271a5
caa9cbd
8b41bfb
550eb70
e5d7359
8473d9a
0570bd6
aaa33fb
e0deca9
841ad22
aab8bff
40a919b
36b3b44
aa80df2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This comment was marked as duplicate.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use a timestamp for one selector and a msgid for the other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions for more FAIL messages:
UNKNOWN_CRITERIA <criteria>
— for if someone specifies an invalid criteria like wibble=foo instead of e.g. msgid=abc123.INVALID_CRITERIA <criteria>
— for if someone specifies a criteria thats not valid for a command e.g. the wildcard (*
) criteria with a non-LATEST command.INVALID_LIMIT <limit>
— for if someone specifies a limit that is out of the allowed range.