[Substrait] Implement CallOp for ScalarFunction message.
#855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingomueller-net
force-pushed
the
substrait-scalar-function
branch
4 times, most recently
from
381d19a to
f512dab
Compare
ingomueller-net
changed the title
CallOp for ScalarFunction message. CallOp for ScalarFunction message.
jpienaar
reviewed
Jul 22, 2024
| message it is contained in. | ||
|
|
||
| Currently, the specification of the function, which is in an external YAML | ||
| file, is not taken into account, for example, to verify whether a matching |
jpienaar
approved these changes
Jul 22, 2024
ingomueller-net
force-pushed
the
substrait-scalar-function
branch
2 times, most recently
from
36ead5e to
35b0303
Compare
This allows to use the externally declared functions from iree-org#853 as scalar function calls (which have the semantics of a typical function call). The current design anticipates that aggregate and window functions can be modelled with the same op, but future PR will need to show if and how that is possible. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
force-pushed
the
substrait-scalar-function
branch
from
35b0303 to
4cfa5c3
Compare
ingomueller-net
added a commit
to substrait-io/substrait-mlir-contrib
that referenced
this pull request
Oct 15, 2024
…g/iree-llvm-sandbox#855) This allows to use the externally declared functions from iree-org/iree-llvm-sandbox#853 as scalar function calls (which have the semantics of a typical function call). The current design anticipates that aggregate and window functions can be modelled with the same op, but future PR will need to show if and how that is possible. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
added a commit
to substrait-io/substrait-mlir-contrib
that referenced
this pull request
Oct 15, 2024
…g/iree-llvm-sandbox#855) This allows to use the externally declared functions from iree-org/iree-llvm-sandbox#853 as scalar function calls (which have the semantics of a typical function call). The current design anticipates that aggregate and window functions can be modelled with the same op, but future PR will need to show if and how that is possible. Signed-off-by: Ingo Müller <ingomueller@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on and, therefor, includes #853.This allows to use the externally declared functions from #853 as scalar
function calls (which have the semantics of a typical function call).
The current design anticipates that aggregate and window functions can
be modelled with the same op, but future PR will need to show if and how
that is possible.