Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] Move inclusion of tools directory up #11685

Merged
merged 2 commits into from
Dec 30, 2022
Merged

[cmake] Move inclusion of tools directory up #11685

merged 2 commits into from
Dec 30, 2022

Conversation

jpienaar
Copy link
Member

@jpienaar jpienaar commented Dec 30, 2022 •
edited
Loading

Results in phony rules generated for both tools and Python to refer to those in tools/ in short form. That is, iree-compile phony target now refers to tools/iree-compile rather than the one inside _mlir_libs:

$ rg -e "build iree-dump-module" -e "build iree-lld" -e "build iree-compile"  build.ninja
211387:build iree-compile: phony tools/iree-compile
211391:build iree-dump-module: phony tools/iree-dump-module
211397:build iree-lld: phony compiler/bindings/python/iree/compiler/_mlir_libs/iree-lld

Fixes #9329.

@jpienaar
[cmake] Move inclusion of tools directory up
80aeb79 
Results in phony rules generated for both tools and Python to refer to those tools in short form (e.g., iree-compile phony target refers to tools/iree-compile rather than the one inside _mlir_libs)..
@jpienaar jpienaar marked this pull request as ready for review December 30, 2022 21:58
@jpienaar jpienaar enabled auto-merge (squash) December 30, 2022 21:58
stellaraccident
stellaraccident approved these changes Dec 30, 2022
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
@jpienaar jpienaar merged commit 702929a into iree-org:main Dec 30, 2022
pzread pushed a commit to pzread/iree that referenced this pull request Jan 4, 2023
Revert "[cmake] Move inclusion of tools directory up (iree-org#11685)"
e77648e 
This reverts commit 702929a.
pzread pushed a commit to pzread/iree that referenced this pull request Jan 11, 2023
Revert "[cmake] Move inclusion of tools directory up (iree-org#11685)"
50b31bb 
This reverts commit 702929a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellaraccident stellaraccident stellaraccident approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing iree-compile and tools/iree-compile targets
2 participants
@jpienaar @stellaraccident