Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Use %10 as default flagging threshold for x86_64 benchmarks #12915

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

antiagainst
Copy link
Contributor

x86_64 benchmarks are not stable in general. Use a larger
threshold to avoid being noisy.

@antiagainst antiagainst added the infrastructure/benchmark Relating to benchmarking infrastructure label Apr 4, 2023
@GMNGeoffrey
Copy link
Contributor

I think @pzread is also about to switch us over to c2-std-60 VMs, which means we get basically an entire VM to ourselves. This might be redundant with that. I'll let him make the call

@pzread
Copy link
Contributor

pzread commented Apr 4, 2023

I think @pzread is also about to switch us over to c2-std-60 VMs, which means we get basically an entire VM to ourselves. This might be redundant with that. I'll let him make the call

I'm fine to first loose the thresholds, we can re-adjust once the new data from c2-std-60 come in.

@antiagainst antiagainst enabled auto-merge (squash) April 4, 2023 16:37
@antiagainst antiagainst merged commit d474394 into iree-org:main Apr 4, 2023
@antiagainst antiagainst deleted the cpu-thresholds-2 branch April 4, 2023 18:57
jpienaar pushed a commit that referenced this pull request May 1, 2023
)

x86_64 benchmarks are not stable in general. Use a larger
threshold to avoid being noisy.
NatashaKnk pushed a commit to NatashaKnk/iree that referenced this pull request Jul 6, 2023
…e-org#12915)

x86_64 benchmarks are not stable in general. Use a larger
threshold to avoid being noisy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure/benchmark Relating to benchmarking infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants