Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GH actions with Dependabot #19663

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

marbre
Copy link
Member

@marbre marbre commented Jan 10, 2025

@marbre marbre requested a review from ScottTodd January 10, 2025 15:05
version: 2
updates:

# Check for updates to GitHub Actions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I iterate on it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a single group and Dependabot PR now looks like marbre#7.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like that more. If we run into issues we can then either take over ourselves or split into a few finer-grained groups, like

  • "core" (actions/checkout, actions/setup-python, etc.)
  • "releasing" (eregon/publish-release, ncipollo/release-action, dwenegar/upload-release-assets)
  • "utility" (peter-evans/create-pull-request, hendrikmuhs/ccache-action), or just "everything else"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting into between what lives in actions/* and "rest of the world" could be a good start. WDYT? I can send a follow up if that makes sense to you.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's live with this for a bit and then split as needed.

@marbre marbre force-pushed the dependabot-gh-actions branch from fffabcb to bb69469 Compare January 13, 2025 11:57
@marbre marbre requested a review from ScottTodd January 13, 2025 11:59
@marbre marbre force-pushed the dependabot-gh-actions branch from bb69469 to dc0bed2 Compare January 13, 2025 12:12
Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some motivating context to the PR description?

Maybe

  • link to best practices from openssf
  • link to dependabot docs

version: 2
updates:

# Check for updates to GitHub Actions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I like that more. If we run into issues we can then either take over ourselves or split into a few finer-grained groups, like

  • "core" (actions/checkout, actions/setup-python, etc.)
  • "releasing" (eregon/publish-release, ncipollo/release-action, dwenegar/upload-release-assets)
  • "utility" (peter-evans/create-pull-request, hendrikmuhs/ccache-action), or just "everything else"

@marbre marbre merged commit 2b29155 into iree-org:main Jan 13, 2025
37 checks passed
@marbre marbre deleted the dependabot-gh-actions branch January 13, 2025 19:00
@ScottTodd ScottTodd mentioned this pull request Feb 4, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants