Port compiler and iree-dialects to nanobind #19790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream MLIR ported its Python bindings from pybind11 to nanobind and so do we. With this we have a single library for the binding across the compiler, iree-dialects and the runtime. The macOS build is expected to still fail, see iree-org#19591, but as upstream switched to build the bindings for the internal dialects with nanobind it does anyway without reverts carried forward in our LLVM fork.
marbre
requested review from
MaheshRavishankar and
stellaraccident
as code owners
ScottTodd
approved these changes
Jan 23, 2025
ScottTodd
added
bindings/python
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream MLIR ported its Python bindings from pybind11 to nanobind and so do we. With this we have a single library for the binding across the compiler, iree-dialects and the runtime.
The macOS build is expected to still fail, see #19591, but as upstream switched to build the bindings for the internal dialects with nanobind it does anyway without reverts carried forward in our LLVM fork.