[Stream][NFC] Iterate over blocks to find return op #19791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
benvanik
approved these changes
Jan 23, 2025
compiler/src/iree/compiler/Dialect/Stream/Transforms/RefineUsage.cpp
Outdated
Show resolved
Hide resolved
IanWood1
changed the title
|
Great work on these compile time improvements! |
Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auto anyReturnOp = *op.getOps<IREE::Util::ReturnOp>().begin();is expensive whenopcontains lots of ops to traverse before finding a return op. Instead, look at each contained block for a return op.On 405b sharded, this reduces compile time from 2min -> 10sec for this pass