Bump tracy to wolfpld/tracy@5479a42 and update local build system. #19842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
commented
Jan 29, 2025
| @@ -27,38 +27,71 @@ else() | |||
|
|
|||
| # Deps slightly differ by platform but some are common. | |||
| pkg_check_modules(TRACY_DEPS | |||
| tbb | |||
| libzstd | |||
There was a problem hiding this comment.
Might be able to use https://github.com/wolfpld/tracy/tree/master/zstd and https://github.com/wolfpld/tracy/blob/16405715a6e4932c2b67548f433498f1bd93b619/cmake/vendor.cmake#L104-L146 instead of an install for this too
benvanik
approved these changes
Jan 29, 2025
Yep! I did not test the cpu profiling though. I only tested that the tools built and CI passed. |
ita9naiwa
pushed a commit
to ita9naiwa/iree
that referenced
this pull request
Feb 4, 2025
…ree-org#19842) Closes iree-org#19801 (this is an alternate version of that PR). This updates us from [Tracy v0.11.0](https://github.com/wolfpld/tracy/releases/tag/v0.11.0) (at wolfpld/tracy@0753956) to a development version of v0.11.2 at wolfpld/tracy@5479a42. The relevant sections of the upstream changelog [can be viewed here](https://github.com/wolfpld/tracy/blob/5479a42ef9346b64e6d1b860ae58aa8abdb0c7f6/NEWS#L5-L65). Notably for our usage: * csvexport improvements, including support for exporting plots and GPU zones * UI improvements, including a new flame graph feature * More bundled dependencies, letting us prune some dockerfiles and build scripts * The dependency on TBB, installed at the system level, was replaced with a source dependency on https://github.com/GabTux/PPQSort * (From 0.11.0) Tracy supports using a known version of the capstone library, rather than a system install. We now use this, fixing iree-org#16777. Signed-off-by: Hyunsung Lee <ita9naiwa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19801 (this is an alternate version of that PR).
This updates us from Tracy v0.11.0 (at wolfpld/tracy@0753956) to a development version of v0.11.2 at wolfpld/tracy@5479a42.
The relevant sections of the upstream changelog can be viewed here. Notably for our usage: