[CPU] Add support for parsing AArch64 cpu features. #19881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hanhanW <hanhan0912@gmail.com>
hanhanW
commented
Feb 3, 2025
There was a problem hiding this comment.
The logic is inspired from the AArch64AsmParser. I honestly dont know if it is a proper fix or not, and I don't know how if we need a test or not.
I can reproduce the issue (using mnist12) on my mac, and the PR does address the issue.
Signed-off-by: hanhanW <hanhan0912@gmail.com>
|
Actually, I only verified that it fixes the compilation. For runtime, it crashes with |
Yeah, the runtime error is definitely something else. |
|
I see, thanks for the review! |
ita9naiwa
pushed a commit
to ita9naiwa/iree
that referenced
this pull request
Feb 4, 2025
A step towards iree-org#19873 --------- Signed-off-by: hanhanW <hanhan0912@gmail.com> Signed-off-by: Hyunsung Lee <ita9naiwa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step towards #19873