[runtime][python] add f8 element types #19928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These types are not available in numpy so no interoperability is provided for them. Signed-off-by: Boian Petkantchin <boian.petkantchin@amd.com>
AWoloszyn
reviewed
Feb 6, 2025
runtime/bindings/python/hal.cc
Outdated
| @@ -1350,6 +1350,10 @@ void SetupHalBindings(nanobind::module_ m) { | |||
| .value("UINT_16", IREE_HAL_ELEMENT_TYPE_UINT_16) | |||
| .value("UINT_32", IREE_HAL_ELEMENT_TYPE_UINT_32) | |||
| .value("UINT_64", IREE_HAL_ELEMENT_TYPE_UINT_64) | |||
| .value("FLOAT_8_E4M3", IREE_HAL_ELEMENT_TYPE_FLOAT_8_E4M3) | |||
There was a problem hiding this comment.
These should probably go at the end to keep this list in the same order as
runtime/src/iree/hal/buffer_view.h
AWoloszyn
approved these changes
Feb 6, 2025
Signed-off-by: Boian Petkantchin <boian.petkantchin@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These types are not available in NumPy so no interoperability is provided for them.