Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add :focus pseudoclass to ComboBox. #357

Merged
merged 2 commits into from
May 16, 2024
Merged

Add :focus pseudoclass to ComboBox. #357

merged 2 commits into from
May 16, 2024

Conversation

zdpcdt
Copy link
Collaborator

@zdpcdt zdpcdt commented May 15, 2024

close #352

@zdpcdt
Copy link
Collaborator Author

zdpcdt commented May 15, 2024

Is it necessary to add AdornerLayer default Theme?

@zdpcdt zdpcdt requested a review from rabbitism May 15, 2024 10:47
@zdpcdt zdpcdt changed the title Add :focus-visible pseudoclass to ComboBox. Add :focus pseudoclass to ComboBox. May 15, 2024
@rabbitism
Copy link
Member

rabbitism commented May 16, 2024 •
edited
Loading

Nice, let's fix the issue first and design focus adorner later.

@rabbitism rabbitism merged commit b45272d into main May 16, 2024
@zdpcdt zdpcdt deleted the issue/352 branch May 16, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabbitism rabbitism rabbitism approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ComboBoxItem should have focus style
2 participants
@zdpcdt @rabbitism