Enhance Carousel #473
Merged
Enhance Carousel #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zdpcdt
commented
Nov 20, 2024
•
zdpcdt
commented
- fix Carousel's ItemContainerTheme as Line Fixes ListBox Width Instead of Item Width #468
- Redesigned inner control positioning in Carousel.
- Navigation bar and previous/next buttons are now hidden when the Carousel has one or fewer items.
|
Originally, we had multiple layers for indicator items because we want them to have wider clickable area compared to visual dots/lines. But surprisingly Semi Design is not designed like this now. So, I think it's correct to simplify the templates. |
rabbitism
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.