R4R: Add pagination params for lcd validators query #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should add pagination for all list query. |
wukongcheng
reviewed
Mar 4, 2019
client/stake/lcd/query.go
Outdated
| @@ -68,7 +68,7 @@ func registerQueryRoutes(cliCtx context.CLIContext, r *mux.Router, cdc *codec.Co | |||
|
|
|||
| // Get all validators | |||
| r.HandleFunc( | |||
| "/stake/validators", | |||
| "/stake/validators/{page}/{size}", | |||
There was a problem hiding this comment.
Move the page and pagesize out of the URL. They should be the params instead of the restful URL.
wukongcheng
previously approved these changes
Mar 4, 2019
wukongcheng
approved these changes
Mar 5, 2019
HaoyangLiu
approved these changes
Mar 5, 2019
This was referenced Apr 19, 2024
This was referenced Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1330