Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Refactor mint module #2102

Merged
merged 19 commits into from
Dec 10, 2019
Merged

R4R: Refactor mint module #2102

merged 19 commits into from
Dec 10, 2019

Conversation

dreamer-zq
Copy link
Contributor

Resolves: #2089

@dreamer-zq dreamer-zq self-assigned this Nov 28, 2019
chengwenxi
chengwenxi reviewed Nov 28, 2019
View reviewed changes
modules/mint/abci.go Outdated Show resolved Hide resolved
chengwenxi
chengwenxi reviewed Nov 28, 2019
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
@dreamer-zq dreamer-zq changed the title WIP: Refactor mint module R4R: Refactor mint module Nov 29, 2019
chengwenxi
chengwenxi suggested changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@chengwenxi chengwenxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some comments, and I think we should add staking interface here to get the StakeDenom.

chengwenxi
chengwenxi suggested changes Dec 5, 2019
View reviewed changes
modules/mint/internal/keeper/keeper.go Outdated Show resolved Hide resolved
modules/mint/internal/types/params.go Outdated Show resolved Hide resolved
modules/mint/internal/types/params.go Outdated Show resolved Hide resolved
simapp/app.go Outdated Show resolved Hide resolved
@chengwenxi chengwenxi merged commit 2c4a343 into irisnet:v1.0.0-refactor Dec 10, 2019
@dreamer-zq dreamer-zq deleted the v1.0.0-refactor branch December 10, 2019 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SegueII SegueII SegueII approved these changes

@chengwenxi chengwenxi chengwenxi approved these changes

@haifengxi haifengxi Awaiting requested review from haifengxi

@zhangyelong zhangyelong Awaiting requested review from zhangyelong

@secret2830 secret2830 Awaiting requested review from secret2830

Assignees

@dreamer-zq dreamer-zq

Labels
API CLI client enhancement New feature or improvement mint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamer-zq @SegueII @chengwenxi