New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Refactor service module #2117

Merged

chengwenxi merged 44 commits into v1.0.0-refactor from secret/refactor-service

Dec 19, 2019

Contributor

secret2830 commented Dec 3, 2019

Resolves: #2093


          refactor service module

secret2830 added refactoring service labels

secret2830 requested review from SegueII, haifengxi, dreamer-zq, chengwenxi and zhangyelong

December 3, 2019 08:09

secret2830 self-assigned this

secret2830 added 21 commits

December 3, 2019 16:41

fix

6f10e26


          add events

17ebde8


          optimize genesis handling

b3b24a0


          refactor querier

64678da


          fix keeper

97864cf


          refactor params

6eae648


          refactor keeper

86b9a1f


          refactor handler

7cf5f0a


          optimize keeper

3a65b40


          add module accounts

d97056e


          add module log

33e154d


          add burn interface for supply

56e53be


          fix abci

e39260c


          refactor PreForZeroHeightGenesis

f28f3b5


          modify method parsing and metrics

fdad95f


          fix msgs

a325d0c


          refactor params validation

a1bff1c


          add simulation

e19e8f9


          refactor cli

40c6435


          refactor rest

fd79bc0


          add service to app

8f24d3f

dreamer-zq reviewed

View reviewed changes

modules/service/abci.go Outdated Show resolved Hide resolved

dreamer-zq reviewed

View reviewed changes

modules/service/abci.go Outdated Show resolved Hide resolved

dreamer-zq reviewed

View reviewed changes

modules/service/client/rest/rest.go Outdated Show resolved Hide resolved

dreamer-zq reviewed

View reviewed changes

modules/service/internal/keeper/binding.go Show resolved Hide resolved

dreamer-zq reviewed

View reviewed changes

modules/service/internal/keeper/binding.go Outdated Show resolved Hide resolved

dreamer-zq reviewed

View reviewed changes

modules/service/internal/types/expected_keepers.go Outdated Show resolved Hide resolved

dreamer-zq reviewed

View reviewed changes

modules/service/internal/types/params.go Show resolved Hide resolved

dreamer-zq reviewed

View reviewed changes

modules/service/internal/types/querier.go Outdated Show resolved Hide resolved

chengwenxi reviewed

View reviewed changes

modules/service/internal/types/metrics.go Outdated Show resolved Hide resolved

chengwenxi reviewed

View reviewed changes

modules/service/internal/types/params.go Show resolved Hide resolved

secret2830 changed the title ~~WIP: Refactor service module~~ R4R: Refactor service module

secret2830 added 8 commits

December 17, 2019 09:49


          reorganize cli

d9f8cd2


          add yaml tags and optimize imports

237a3c2

fix

3fd5b69

fix

a818a62


          fix and optimize

905e3ad


          add exported types for guardian

1d4bac0


          add some tests to TODO

4b89fde


          fix conflicts

3d54e68

golangcibot reviewed

View reviewed changes

modules/service/internal/types/params.go Outdated Show resolved Hide resolved

modules/service/internal/types/params.go Outdated Show resolved Hide resolved

modules/service/internal/types/params.go Outdated Show resolved Hide resolved


          add TODO to cli test

b3c2c9a

golangcibot reviewed

View reviewed changes

modules/service/internal/types/params.go Outdated Show resolved Hide resolved

secret and others added 5 commits

December 17, 2019 12:38


          fix cli test

daa2e03


          fix bug and make unit tests pass

2e17fa9


          all proto utils

786acc1


          fix unit tests

49501e2


          remove metrics and fix cli test

bd9548b

chengwenxi approved these changes

View reviewed changes

Contributor

chengwenxi left a comment

utACK

chengwenxi merged commit 3ebbca4 into v1.0.0-refactor

chengwenxi deleted the secret/refactor-service branch

December 19, 2019 07:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dreamer-zq dreamer-zq left review comments

golangcibot golangcibot left review comments

chengwenxi chengwenxi approved these changes

SegueII Awaiting requested review from SegueII

haifengxi Awaiting requested review from haifengxi

zhangyelong Awaiting requested review from zhangyelong

Labels

refactoring service