Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Refactor coinswap module #2123

Merged
merged 9 commits into from
Dec 13, 2019
Merged

R4R: Refactor coinswap module #2123

merged 9 commits into from
Dec 13, 2019

Conversation

SegueII
Copy link
Contributor

@SegueII SegueII commented Dec 3, 2019

Resolves: #2094

@SegueII SegueII self-assigned this Dec 3, 2019
chengwenxi
chengwenxi reviewed Dec 10, 2019
View reviewed changes
Copy link
Contributor

@chengwenxi chengwenxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace require with suite in unit tests.

modules/coinswap/internal/keeper/keeper.go Outdated Show resolved Hide resolved
@SegueII SegueII changed the title WIP: Refactor coinswap module R4R: Refactor coinswap module Dec 11, 2019
chengwenxi
chengwenxi suggested changes Dec 13, 2019
View reviewed changes
modules/coinswap/internal/types/params.go Outdated Show resolved Hide resolved
modules/coinswap/internal/types/params.go Show resolved Hide resolved
modules/coinswap/internal/types/utils.go Show resolved Hide resolved
@chengwenxi chengwenxi merged commit b12605a into v1.0.0-refactor Dec 13, 2019
@chengwenxi chengwenxi deleted the segue/refactor-coinswap branch December 13, 2019 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamer-zq dreamer-zq dreamer-zq left review comments

@chengwenxi chengwenxi chengwenxi approved these changes

@haifengxi haifengxi Awaiting requested review from haifengxi

@secret2830 secret2830 Awaiting requested review from secret2830

@zhangyelong zhangyelong Awaiting requested review from zhangyelong

Assignees

@SegueII SegueII

Labels
API CLI client coin-swap refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SegueII @dreamer-zq @chengwenxi