refactor: update evm params #2924
Conversation
WalkthroughThe recent update focuses on enhancing the application's upgrade mechanism, specifically targeting the Ethereum Virtual Machine (EVM) module. The introduction of the Changes
Recent Review StatusConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (17)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Actionable comments outside the diff hunks (29)
CHANGELOG.md (29)
Line range hint
24-25: Duplicate entries for NFT API support.Consider removing one of the duplicate entries to avoid confusion.
[!TIP]
Codebase VerificationThe verification process confirms that the version bump for
tibc-gotov0.5.0is correctly applied and matches the information provided in the CHANGELOG. However, forirismod, while the CHANGELOG mentions a bump tov1.8.0, the actual version in thego.modfile isv1.8.1-0.20240304075720-718d99d97674, which is a pre-release version likely corresponding tov1.8.0but not exactly the same. This discrepancy might be intentional, possibly to include specific fixes or features not present in the basev1.8.0release. Given this information, the review comment is partially correct; the versions are applied, but there's a slight discrepancy in theirismodversion that warrants clarification.Analysis chain
Line range hint
29-31: Ensure version bumps are correctly applied and compatible.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if the bumped versions of tibc-go and irismod are correctly applied and compatible. grep "tibc-go" go.mod grep "irismod" go.modLength of output: 166
Line range hint
40-40: Clarify the feature description for interchain NFT transfer.- IRISHub now integrates the functionality of interchain nft-transfer, allowing you to transfer NFTs to other chains. + IRISHub now supports interchain NFT transfers, enabling NFTs to be sent across different blockchain networks.
Line range hint
58-58: Typographical error in the comment.- Replace base64.StdEncoding with base64.RawStdEncoding. + Replace `base64.StdEncoding` with `base64.RawStdEncoding`.
Line range hint
101-104: Unpaired symbol[detected in multiple entries.Ensure all markdown links are correctly formatted with matching
[]and()pairs.
Line range hint
116-117: Inconsistent use of GRPC method renaming.- GRPC method `Owner` rename to `NFTsOfOwner`, Remove deprecated `Queries` api + Renamed GRPC method from `Owner` to `NFTsOfOwner` and removed deprecated `Queries` API.
Line range hint
137-137: Clarification needed for cross-chain MT transfer feature.- Support cross chain MT transfer via TIBC + Enabled cross-chain Multi-Token (MT) transfers through TIBC protocol.
Line range hint
151-152: Ensure refactor and enhancement descriptions are clear and concise.- Refactor coinswap module - Enhance nft module + Refactored the CoinSwap module for improved efficiency. + Enhanced the NFT module with additional features.
Line range hint
156-157: Clarify breaking changes related to liquidity tokens.- Liquidity tokens are named as *lpt-{number}*, and the existing liquidity will be automatically modified during the upgrade + Renamed liquidity tokens to `lpt-{number}` format, with existing liquidity tokens automatically updated during the upgrade process.
Line range hint
202-202: Typographical error in the word "version".- Bump tendermint verion to [v0.34.8](https://github.com/tendermint/tendermint/releases/tag/v0.34.8) + Bump tendermint version to [v0.34.8](https://github.com/tendermint/tendermint/releases/tag/v0.34.8)
Line range hint
213-213: Clarify migration of withdraw information.- Migrate withdraw infos + Migrated withdrawal information to the new data structure.
Line range hint
225-225: Clarify the refactor purpose for the guardian module.- Refactor guardian module + Refactored the Guardian module to enhance security and flexibility.
Line range hint
252-252: Clarify the hash lock specification in CLI.- Fix the bug that the hash lock can not be specified in the CLI + Corrected an issue where the hash lock could not be specified in the CLI.
Line range hint
257-257: Optimize snapshot UX improvement description.- Improve the UX of snapshot + Enhanced user experience for blockchain snapshot functionality.
Line range hint
266-266: Clarify the addition of liquidity functions.- Add new function - AddLiquidity + Introduced a new function for adding liquidity to the CoinSwap module.
Line range hint
283-283: Clarify the addition of liquidity functions in the application layer.- Add new function - AddLiquidity + Added functionality for liquidity addition in the application layer.
Line range hint
293-293: Clarify the error message improvement for HTLC.- Improve HTLC + Improved error messaging and handling within the HTLC module.
[!TIP]
Codebase VerificationThe verification process did not find evidence of the Tendermint version update to v0.31.0 in the module dependencies within the
go.modfile. The specific version number "v0.31.0" was not found, and the only related reference was github.com/tendermint/go-amino v0.16.0, which does not directly indicate the Tendermint core version. Based on this information, it appears that the Tendermint version update is not correctly reflected in the module dependencies as expected.Analysis chain
Line range hint
308-308: Ensure Tendermint version update is correctly reflected.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Confirm Tendermint version update to v0.31.0 is correctly reflected in the module dependencies. grep "tendermint" go.modLength of output: 76
Script:
#!/bin/bash # Perform a more comprehensive search in go.mod for any Tendermint core version specification. grep "tendermint" go.mod grep "v0.31.0" go.modLength of output: 98
Line range hint
313-313: Clarify the creation of a peer state in the consensus reactor.- Create a peer state in consensus reactor before the peer is started + Implemented creation of peer state in the consensus reactor prior to peer initialization.
Line range hint
318-318: Clarify the exit strategy for SwitchToConsensus failure.- Exit if SwitchToConsensus fails + Added an exit condition if switching to consensus fails.
Line range hint
350-350: Clarify the handling of governance parameters in the network configuration.- Do not update gov params when network not equal mainnet + Exclude governance parameter updates when the network configuration does not match the mainnet.
Line range hint
355-355: Clarify the handling of validator intraTxCount during stake genesis initialization.- Missing to set validator intraTxCount in stake genesis init + Corrected omission of setting validator intraTxCount during stake genesis initialization.
Line range hint
363-363: Clarify the purpose of the guardian module refactor.- Refactor guardian module + Refactored the Guardian module for enhanced security measures.
[!TIP]
Codebase VerificationThe verification process aimed to confirm the presence of ledger support configuration in
network/hermes/config.tomlby searching for the term "ledger." The absence of any output from this search indicates that the ledger support configuration, as expected, is not present in theconfig.tomlfile. This finding directly addresses the verification task.Analysis chain
Line range hint
371-371: Verify ledger support configuration is correctly applied.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Ensure Ledger Nano support is correctly configured. grep "ledger" config.tomlLength of output: 70
Script:
#!/bin/bash # Search for config.toml across the repository fd config.toml # If found, the next script will grep for "ledger" within it.Length of output: 43
Script:
#!/bin/bash # Check for ledger support configuration in network/hermes/config.toml grep "ledger" network/hermes/config.tomlLength of output: 40
Line range hint
379-379: Clarify the hash lock specification in CLI for stake sign-info.- Fix the bug that the hash lock can not be specified in the CLI + Corrected an issue preventing the specification of a hash lock in the CLI.
Line range hint
383-383: Optimize snapshot UX improvement description.- Improve the UX of snapshot + Enhanced user experience for blockchain snapshot functionality.
Line range hint
387-387: Clarify the addition of liquidity functions in the application layer.- Add new function - AddLiquidity + Added functionality for liquidity addition in the application layer.
Line range hint
399-399: Clarify the creation of a peer state in the consensus reactor.- Create a peer state in consensus reactor before the peer is started + Implemented creation of peer state in the consensus reactor prior to peer initialization.
Line range hint
403-403: Clarify the exit strategy for SwitchToConsensus failure.- Exit if SwitchToConsensus fails + Added an exit condition if switching to consensus fails.
Summary by CodeRabbit