When the baseFee of the token is an external asset, issue&mint Token error #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SegueII
approved these changes
Jan 29, 2021
chengwenxi
approved these changes
Feb 1, 2021
dreamer-zq
added a commit
that referenced
this pull request
Feb 1, 2021
Update symbol&minUint validation (#95) * Optimized token accuracy conversion * update symbol&minUint validation * adjust test case modify service event name (#96) Co-authored-by: secret <secret@bianjie.ai> Release v1.2.1 (#98) * update v1.2.1 changelog * add links Mint&Edit&Burn only accept symbol as denom (#101) * Optimized token accuracy conversion * mint&edit&burn only accept symbol as denom * revert code * revert code * refactor GetToken method When the baseFee of the token is an external asset, issue&mint Token error (#103) * Optimized token accuracy conversion * mint&edit&burn only accept symbol as denom * revert code * revert code * handle error * revert Fix burn token (#104) * fix burn token * add changelog "TotalBurn" method remove unit convert (#97) * Optimized token accuracy conversion * remove TotalBurn unit convert * fix test error
chengwenxi
pushed a commit
that referenced
this pull request
Feb 2, 2021
* Optimized token accuracy conversion * fix base fee calc error * check token exist in InitGenesis * Optimized token accuracy conversion Update symbol&minUint validation (#95) * Optimized token accuracy conversion * update symbol&minUint validation * adjust test case modify service event name (#96) Co-authored-by: secret <secret@bianjie.ai> Release v1.2.1 (#98) * update v1.2.1 changelog * add links Mint&Edit&Burn only accept symbol as denom (#101) * Optimized token accuracy conversion * mint&edit&burn only accept symbol as denom * revert code * revert code * refactor GetToken method When the baseFee of the token is an external asset, issue&mint Token error (#103) * Optimized token accuracy conversion * mint&edit&burn only accept symbol as denom * revert code * revert code * handle error * revert Fix burn token (#104) * fix burn token * add changelog "TotalBurn" method remove unit convert (#97) * Optimized token accuracy conversion * remove TotalBurn unit convert * fix test error * fix base fee calc error * check token exist in InitGenesis * uint64(MaxUint64) * fix unit64->int64 error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue: 102