-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove super mode from service #118
Conversation
binding, _ := k.GetServiceBinding(ctx, serviceName, provider) | ||
serviceFee = k.GetPrice(ctx, consumer, binding) | ||
} | ||
binding, _ := k.GetServiceBinding(ctx, serviceName, provider) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ignore err ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an internal method as described in its comment.
@@ -1122,7 +1115,7 @@ func (k Keeper) CheckAuthority( | |||
return sdkerrors.Wrap(types.ErrUnknownRequestContext, requestContextID.String()) | |||
} | |||
|
|||
if !consumer.Equals(consumer) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
Remove super mode from service: