Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance nft module #189

Merged
merged 17 commits into from
Jul 12, 2021
Merged

Enhance nft module #189

merged 17 commits into from
Jul 12, 2021

Conversation

mindcarver
Copy link
Contributor

@mindcarver mindcarver commented Jun 10, 2021 •
edited
Loading

refer: #183

@mindcarver mindcarver self-assigned this Jun 18, 2021
@chengwenxi chengwenxi added modules/nft Changes, features and bugs related to the nft module. enhancement New feature or request labels Jun 24, 2021
@mindcarver mindcarver changed the title Add the symbol field to Denom Enhance nft module Jul 5, 2021
@mindcarver mindcarver changed the title Enhance nft module WIP:enhance nft module Jul 5, 2021
chengwenxi
chengwenxi reviewed Jul 6, 2021
View reviewed changes
modules/nft/client/cli/cli_test.go Outdated Show resolved Hide resolved
modules/nft/client/cli/flags.go Show resolved Hide resolved
modules/nft/client/cli/tx.go Outdated Show resolved Hide resolved
modules/nft/client/cli/tx.go Outdated Show resolved Hide resolved
modules/nft/client/cli/tx.go Outdated Show resolved Hide resolved
modules/nft/keeper/keeper.go Outdated Show resolved Hide resolved
modules/nft/keeper/keeper.go Outdated Show resolved Hide resolved
modules/nft/keeper/keeper.go Outdated Show resolved Hide resolved
modules/nft/keeper/msg_server.go Show resolved Hide resolved
modules/nft/types/errors.go Outdated Show resolved Hide resolved
@chengwenxi chengwenxi changed the title WIP:enhance nft module Enhance nft module Jul 6, 2021
chengwenxi
chengwenxi suggested changes Jul 7, 2021
View reviewed changes
modules/nft/keeper/keeper.go Outdated Show resolved Hide resolved
modules/nft/keeper/keeper.go Outdated Show resolved Hide resolved
@chengwenxi chengwenxi added automerge Automatically merge PR once all prerequisites pass. and removed automerge Automatically merge PR once all prerequisites pass. labels Jul 12, 2021
@chengwenxi chengwenxi merged commit d992695 into irisnet:master Jul 12, 2021
@mindcarver mindcarver mentioned this pull request Jul 18, 2021
Closed
3 tasks
This was referenced Apr 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengwenxi chengwenxi chengwenxi approved these changes

@Nicke-lucky Nicke-lucky Nicke-lucky approved these changes

@dreamer-zq dreamer-zq Awaiting requested review from dreamer-zq

Assignees

@mindcarver mindcarver

Labels
enhancement New feature or request modules/nft Changes, features and bugs related to the nft module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mindcarver @chengwenxi @Nicke-lucky