Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: farm genesis validation #380

Merged
merged 2 commits into from
Oct 11, 2023
Merged

fix: farm genesis validation #380

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9304e04
fix: farm genesis validation
taramakage Oct 10, 2023
de46200
remove redundant conditonal logic
taramakage Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions modules/farm/types/genesis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,17 @@ func ValidateGenesis(data GenesisState) error {
return fmt.Errorf("rewardPerBlock must be positive, but got %s", r.RewardPerBlock.String())
}

// If the unexpired pool rule has been updated, rewardPerShare will not be zero.
if !r.RewardPerShare.IsPositive() {
// No reward has ever been distributed.
if r.RemainingReward.Equal(r.TotalReward) {
continue
}
// The pool is expired and the reward is refund to the creator
if !r.RemainingReward.Equal(r.TotalReward) && pool.EndHeight == pool.LastHeightDistrRewards {
continue
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if pool.EndHeight == pool.LastHeightDistrRewards {
continue
}


return fmt.Errorf("rewardPerShare must be positive, but got %s", r.RewardPerShare.String())
}
}
Expand Down