Code

Exception group stage3#6

Code

Closed

iritkatriel wants to merge 78 commits intoexceptionGroup-stage2iritkatriel/cpython:exceptionGroup-stage2from exceptionGroup-stage3iritkatriel/cpython:exceptionGroup-stage3Copy head branch name to clipboard

+1,390-38

Commits

Commits on Dec 2, 2020

• first attempt at ExceptionGroup/TracebackGroup

  iritkatriel

  committed
  5655a3e

• implemented traceback group in c - added map field to traceback so it can double up as a traceback group (avoids the need for subclassing it for the demo)

  iritkatriel

  committed
  7c9b194

• add output of exception_group.py

  iritkatriel

  committed
  030818d

• Move ExceptionGroup to types; add asyncio.TaskGroup

  

  1st1

  authored and

  iritkatriel

  committed
  3d01e30

• remove add_exc from ExceptionGroup

  iritkatriel

  committed
  f9ccf22

• pure-python, immutable ExceptionGroup

  iritkatriel

  committed
  404ab68

• revert c changes

  iritkatriel

  committed
  3995d2f

• fixed merging of nested TBGs. Added __iter__ on EG. removed frame from TBG and EG - we take it from the __traceback__ which is set when the EG is raised

  iritkatriel

  committed
  6c78891

• review comments from Guido. Also fixed split, and activated it in the test script

  iritkatriel

  committed
  c0c2833

• move ExceptionGroup and TracebackGroup from types to their own script in Lib

  iritkatriel

  committed
  3ccb921

• added Lib/exception_group.py

  iritkatriel

  committed
  3b4254c

• refreshed output

  iritkatriel

  committed
  79995cd

• added unit tests checking the structure of a simple and nested EG

  iritkatriel

  committed
  90700b7

• assertExceptionMatchesTemplate instad of assertExceptionsMatch to compare the whole structure. Added stubs for split tests

  iritkatriel

  committed
  3257e5b

• added simple split tests

  iritkatriel

  committed
  e95fd95

• added split tests for nexted exception groups

  iritkatriel

  committed
  f729a56

• deleted the old test script and output

  iritkatriel

  committed
  f16f601

• added ExceptionGroupCatcher and tests for simple (swallowing) handler

  iritkatriel

  committed
  a4b31ed

• tidy up tests

  iritkatriel

  committed
  166415d

• added tests for catch with a handler that raises new exceptions (not checking tracebacks yet)

  iritkatriel

  committed
  a177e97

• tidy up tests

  iritkatriel

  committed
  6d78291

• handle case where EG is created with an exception with no traceback (was not raised yet)

  iritkatriel

  committed
  8ff067a

• added ExceptionGroup.extract_traceback to get the traceback of a single exception from the group. Use it to simplify the tests

  iritkatriel

  committed
  e22bd01

• added traceback checks to the Cacther tests. Fixed bug in Catcher's merging of new and old exceptions

  iritkatriel

  committed
  2a6673c

• derive template from the exception in the tests

  iritkatriel

  committed
  ddf4677

• added ExceptionGroup.subgroup() and use it in Catcher to preserve structure of the original exception

  iritkatriel

  committed
  4d66d91

• added more interesting catch tests. removed empty nested EGs from split and subgroup's output

  iritkatriel

  committed
  e7bb3be

• revert change to Lib\types.py

  iritkatriel

  committed
  9b671ab

• update Lib/asyncio/taskgroup.py and tg1 with new location of EG

  iritkatriel

  committed
  618e251

• _split_on_condition --> project

  iritkatriel

  committed
  791ff8d

• use subgroup to simplify extract_traceback

  iritkatriel

  committed
  f6c1442

• don't create a new EG if to_add is empty

  iritkatriel

  committed
  c78848b

• tb_next_map keyed on id(exc). Do we need anything else? (array of tbs? weak refs?)

  iritkatriel

  committed
  1ec4bce

• Guido's review comments (easy ones done, complex ones noted as TODO)

  iritkatriel

  committed
  4d63a8a

• replace __len__ by is_empty

  iritkatriel

  committed
  040ebcf

• make complement EG optional in project()

  iritkatriel

  committed
  286f4ad

• fix TracebackGroup constructor for nested EGs

  iritkatriel

  committed
  742f8fa

• rewrote construction tests, fixed TraceBackGroup init

  iritkatriel

  committed
  e21b368

• rewrote split tests

  iritkatriel

  committed
  91af84d

• make tests more explicit

  iritkatriel

  committed
  0001e28

• call super.__init__ from ExceptionGroup.__init__ and give it the message

  iritkatriel

  committed
  b11a262

• fix test name

  iritkatriel

  committed
  d9929ff

• Change handler API - return True for naked raise or raise some EG

  iritkatriel

  committed
  d4e44cf

• In catcher tests, compare caught exception's traceback to that of the original exception.

  iritkatriel

  committed
  2d96ffa

• reduce boilerplate in tests

  iritkatriel

  committed
  3581143

• use traceback.py types in ExceptionGroup.render/format/extract

  iritkatriel

  committed
  c243e94

• added test for format and render

  iritkatriel

  committed
  7b0b2b4

• traceback.TracebackException is awesome

  iritkatriel

  committed
  100bd46

• Delete tg1.py

  iritkatriel

  committed
  1ddacce

• move extract_traceback to test script

  iritkatriel

  committed
  1faf80a

• pep8 formatting

  iritkatriel

  committed
  025b432

• reduce repetition in tests

  iritkatriel

  committed
  2fd59e7

• move ExceptionGroup formatting to traceback.py

  iritkatriel

  committed
  0d57f35

• Update Lib/traceback.py

  Show description for 4cae22a
  

  iritkatriel

  and

  gvanrossum

  committed
  4cae22a

• Update Lib/traceback.py

  Show description for 8d6a2a9
  

  iritkatriel

  and

  gvanrossum

  committed
  8d6a2a9

• Update Lib/traceback.py

  Show description for f593579
  

  iritkatriel

  and

  gvanrossum

  committed
  f593579

• Update Lib/traceback.py

  Show description for 0276874
  

  iritkatriel

  and

  gvanrossum

  committed
  0276874

• Update Lib/traceback.py

  Show description for 2e5cf25
  

  iritkatriel

  and

  gvanrossum

  committed
  2e5cf25

• Guido's review comments (part1)

  iritkatriel

  committed
  e14f9bb

• move message to be first arg of ExceptionGroup()

  iritkatriel

  committed
  bc38881

• more of Guido's review comments

  iritkatriel

  committed
  5218614

• add indent_level field to TracebackException

  iritkatriel

  committed
  942ac86

• ExceptionGroup takes exceptions as *args instead of list

  iritkatriel

  committed
  51405d2

• make indent 3 instead of 4

  iritkatriel

  committed
  46117d3

• remove tb arg from ExceptionGroup

  iritkatriel

  committed
  7a3df2a

• break up large test function, remove some of the tests that should not

  Show description for 3d25ae7
  iritkatriel

  committed
  3d25ae7

• TracebackExceptionGroup is only for ExceptionGroups, and simper structure. indent_level implied by the recursive structure so removed. Removed render tests from test_exception_groups because that's…

  Show description for dd23f00
  iritkatriel

  committed
  dd23f00

Commits on Dec 7, 2020

• revert unintended changes to other tests

  iritkatriel

  committed
  e36d9b9

• add missing newline at end of file

  iritkatriel

  committed
  22a566f

Commits on Dec 8, 2020

• minor test tidyup

  iritkatriel

  committed
  0a6800c

• ExceptionGroup.project() now (1) checks the ExceptionGroup itself (and nested EGs) for matches and handles them correctly. (2) Returns None instead of empty EGs (3) is a staticmethod

  iritkatriel

  committed
  701cd5d

Commits on Dec 11, 2020

• remove the TracebackGroup class - we don't need it

  iritkatriel

  committed
  26394d8

Commits on Dec 13, 2020

• remove TracebackGroup import in test

  iritkatriel

  committed
  3e3c03f

Commits on Dec 15, 2020

• add ExceptionGroup in C

  iritkatriel

  committed
  1041417

• rudimentary rendering of ExceptionGroups in C

  iritkatriel

  committed
  d0eabc7

Commits on Dec 16, 2020

• nicer rendering of exception groups

  iritkatriel

  committed
  6fb3621

Commits on Dec 23, 2020

• fix the leak that Kyle spotted

  iritkatriel

  committed
  e697d5b

Commits on Dec 30, 2020

• fix second leak

  iritkatriel

  committed
  e10e279