Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Galactic: Fix data race on parameter event #123

Conversation

mauropasse
Copy link
Collaborator

@mauropasse mauropasse commented Oct 10, 2023

The callback 'on_parameter_event' was internally accessing node_base_, which could be already destroyed.

Cherry pick ros2#2320

@mauropasse mauropasse force-pushed the mauro/galactic-fix-data-race-on-params-event branch from 7d9f7e6 to 7bab107 Compare October 16, 2023 11:29
@mauropasse mauropasse changed the title Galactic: fix data race on params event Galactic: Fix data race on parameter event Oct 16, 2023
@alsora alsora merged commit dffd84c into irobot-ros:galactic-events-executor Oct 16, 2023
@mauropasse mauropasse deleted the mauro/galactic-fix-data-race-on-params-event branch October 16, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants