forked from ros2/rmw_fastrtps
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apis to retrieve service/client QoS #27
Open
mauropasse
wants to merge
16
commits into
irobot-ros:irobot/add-events-executor
Choose a base branch
from
mauropasse:mauro/add-events-executor-get-cli-serv-qos
base: irobot/add-events-executor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add apis to retrieve service/client QoS #27
mauropasse
wants to merge
16
commits into
irobot-ros:irobot/add-events-executor
from
mauropasse:mauro/add-events-executor-get-cli-serv-qos
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add constness Move set callback APIs Put unread events in queue when setting callback Put unread events in queue when setting callback Use or discard previous events: Guard conditions Unset callbacks support Rename EventHandle to ExecutorEventHandle Update name Add support for events void return on set_events_executor_callback Revert "void return on set_events_executor_callback" Add mutexes set to nullptr Remove use_executor_callback_, not needed Rename ExecutorEventCallback -> EventsExecutorCallback Rename set_events_executor_callback->set_listener_callback Use data types when setting callbacks Move rcutils/executor_event_types.h to rmw/ rename event types Rename executor_context->callback_context Rename callback_context->user_data Reorder APIs arguments rename rmw_listener_cb_t->rmw_listener_callback_t Only check callback pointer validity This is the only item that is used in the RMW layer, while the others are simply forwarded. use void * to pass executor ptr Rework executor callback data Use RMW renamed file Signed-off-by: Alberto Soragna <asoragna@irobot.com>
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
Rename listener callbacks setters
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
…ecutor Mauro/rebase add events executor
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
Use QoS depth on fastrtps_dynamic_cpp
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
Use size_t for new_data_unread_count_
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
mauropasse
force-pushed
the
mauro/add-events-executor-get-cli-serv-qos
branch
from
October 18, 2021 09:30
62a3edf
to
bea69b8
Compare
wjwwood
force-pushed
the
irobot/add-events-executor
branch
from
January 12, 2022 03:22
e486ede
to
1d643e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mauro Passerino mpasserino@irobot.com