Fail build Rolling

[imstevenpmwork]

rolling branch seems to be failing to build when using ROS rolling with the following output:

Starting >>> performance_test
--- stderr: performance_test
CMake Warning:
  Manually-specified variables were not used by the project:

    SKIP_MULTI_RMW_TESTS


In file included from /zenoh_rmw_eval/ros2_irobot_ws/src/irobot_performance_test/performance_test/include/performance_test/performance_node_base.hpp:260,
                 from /zenoh_rmw_eval/ros2_irobot_ws/src/irobot_performance_test/performance_test/include/performance_test/system.hpp:21,
                 from /zenoh_rmw_eval/ros2_irobot_ws/src/irobot_performance_test/performance_test/test/test_system.cpp:15:
/zenoh_rmw_eval/ros2_irobot_ws/src/irobot_performance_test/performance_test/include/performance_test/performance_node_base_impl.hpp: In instantiation of ‘void performance_test::PerformanceNodeBase::add_client(const std::string&, const rclcpp::QoS&) [with Srv = performance_test_msgs::srv::Sample; std::string = std::__cxx11::basic_string<char>]’:
/zenoh_rmw_eval/ros2_irobot_ws/src/irobot_performance_test/performance_test/include/performance_test/performance_node_base_impl.hpp:164:24:   required from ‘void performance_test::PerformanceNodeBase::add_periodic_client(const std::string&, std::chrono::microseconds, const rclcpp::QoS&, size_t) [with Srv = performance_test_msgs::srv::Sample; std::string = std::__cxx11::basic_string<char>; std::chrono::microseconds = std::chrono::duration<long int, std::ratio<1, 1000000> >; size_t = long unsigned int]’
/zenoh_rmw_eval/ros2_irobot_ws/src/irobot_performance_test/performance_test/test/test_system.cpp:90:71:   required from here
/zenoh_rmw_eval/ros2_irobot_ws/src/irobot_performance_test/performance_test/include/performance_test/performance_node_base_impl.hpp:183:68: error: invalid initialization of reference of type ‘const rclcpp::QoS&’ from expression of type ‘const rmw_qos_profile_t’ {aka ‘const rmw_qos_profile_s’}
  183 |   rclcpp::ClientBase::SharedPtr client = rclcpp::create_client<Srv>(
      |                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^
  184 |     m_node_interfaces.base,
      |     ~~~~~~~~~~~~~~~~~~~~~~~                                         
  185 |     m_node_interfaces.graph,
      |     ~~~~~~~~~~~~~~~~~~~~~~~~                                        
  186 |     m_node_interfaces.services,
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~                                     
  187 |     service_name,
      |     ~~~~~~~~~~~~~                                                   
  188 |     qos_profile.get_rmw_qos_profile(),
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                              
  189 |     nullptr);
      |     ~~~~~~~~                                                        
In file included from /opt/ros/rolling/include/rclcpp/rclcpp/node_impl.hpp:38,
                 from /opt/ros/rolling/include/rclcpp/rclcpp/node.hpp:1627,
                 from /opt/ros/rolling/include/rclcpp/rclcpp/executors/single_threaded_executor.hpp:28,
                 from /opt/ros/rolling/include/rclcpp/rclcpp/executors.hpp:22,
                 from /opt/ros/rolling/include/rclcpp/rclcpp/rclcpp.hpp:172,
                 from /zenoh_rmw_eval/ros2_irobot_ws/src/irobot_performance_test/performance_test/include/performance_test/performance_node_base.hpp:23:
/opt/ros/rolling/include/rclcpp/rclcpp/create_client.hpp:48:23: note: in passing argument 5 of ‘typename rclcpp::Client<ServiceT>::SharedPtr rclcpp::create_client(std::shared_ptr<node_interfaces::NodeBaseInterface>, std::shared_ptr<node_interfaces::NodeGraphInterface>, std::shared_ptr<node_interfaces::NodeServicesInterface>, const std::string&, const QoS&, CallbackGroup::SharedPtr) [with ServiceT = performance_test_msgs::srv::Sample; typename Client<ServiceT>::SharedPtr = std::shared_ptr<Client<performance_test_msgs::srv::Sample> >; std::string = std::__cxx11::basic_string<char>; CallbackGroup::SharedPtr = std::shared_ptr<CallbackGroup>]’
   48 |   const rclcpp::QoS & qos = rclcpp::ServicesQoS(),
      |   ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /zenoh_rmw_eval/ros2_irobot_ws/src/irobot_performance_test/performance_test/include/performance_test/performance_node_base.hpp:260,
                 from /zenoh_rmw_eval/ros2_irobot_ws/src/irobot_performance_test/performance_test/include/performance_test/performance_node.hpp:17,
                 from /zenoh_rmw_eval/ros2_irobot_ws/src/irobot_performance_test/performance_test/test/test_node.cpp:17:
/zenoh_rmw_eval/ros2_irobot_ws/src/irobot_performance_test/performance_test/include/performance_test/performance_node_base_impl.hpp: In instantiation of ‘void performance_test::PerformanceNodeBase::add_client(const std::string&, const rclcpp::QoS&) [with Srv = performance_test_msgs::srv::Sample; std::string = std::__cxx11::basic_string<char>]’:
/zenoh_rmw_eval/ros2_irobot_ws/src/irobot_performance_test/performance_test/include/performance_test/performance_node_base_impl.hpp:164:24:   required from ‘void performance_test::PerformanceNodeBase::add_periodic_client(const std::string&, std::chrono::microseconds, const rclcpp::QoS&, size_t) [with Srv = performance_test_msgs::srv::Sample; std::string = std::__cxx11::basic_string<char>; std::chrono::microseconds = std::chrono::duration<long int, std::ratio<1, 1000000> >; size_t = long unsigned int]’
/zenoh_rmw_eval/ros2_irobot_ws/src/irobot_performance_test/performance_test/test/test_node.cpp:63:64:   required from here
/zenoh_rmw_eval/ros2_irobot_ws/src/irobot_performance_test/performance_test/include/performance_test/performance_node_base_impl.hpp:183:68: error: invalid initialization of reference of type ‘const rclcpp::QoS&’ from expression of type ‘const rmw_qos_profile_t’ {aka ‘const rmw_qos_profile_s’}
  183 |   rclcpp::ClientBase::SharedPtr client = rclcpp::create_client<Srv>(
      |                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^
  184 |     m_node_interfaces.base,
      |     ~~~~~~~~~~~~~~~~~~~~~~~                                         
  185 |     m_node_interfaces.graph,
      |     ~~~~~~~~~~~~~~~~~~~~~~~~                                        
  186 |     m_node_interfaces.services,
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~                                     
  187 |     service_name,
      |     ~~~~~~~~~~~~~                                                   
  188 |     qos_profile.get_rmw_qos_profile(),
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                              
  189 |     nullptr);
      |     ~~~~~~~~                                                        
In file included from /opt/ros/rolling/include/rclcpp_lifecycle/rclcpp_lifecycle/lifecycle_node_impl.hpp:30,
                 from /opt/ros/rolling/include/rclcpp_lifecycle/rclcpp_lifecycle/lifecycle_node.hpp:1097,
                 from /zenoh_rmw_eval/ros2_irobot_ws/src/irobot_performance_test/performance_test/test/test_node.cpp:15:
/opt/ros/rolling/include/rclcpp/rclcpp/create_client.hpp:48:23: note: in passing argument 5 of ‘typename rclcpp::Client<ServiceT>::SharedPtr rclcpp::create_client(std::shared_ptr<node_interfaces::NodeBaseInterface>, std::shared_ptr<node_interfaces::NodeGraphInterface>, std::shared_ptr<node_interfaces::NodeServicesInterface>, const std::string&, const QoS&, CallbackGroup::SharedPtr) [with ServiceT = performance_test_msgs::srv::Sample; typename Client<ServiceT>::SharedPtr = std::shared_ptr<Client<performance_test_msgs::srv::Sample> >; std::string = std::__cxx11::basic_string<char>; CallbackGroup::SharedPtr = std::shared_ptr<CallbackGroup>]’
   48 |   const rclcpp::QoS & qos = rclcpp::ServicesQoS(),
      |   ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
gmake[2]: *** [test/CMakeFiles/test_system.dir/build.make:76: test/CMakeFiles/test_system.dir/test_system.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:232: test/CMakeFiles/test_system.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....
gmake[2]: *** [test/CMakeFiles/test_node.dir/build.make:76: test/CMakeFiles/test_node.dir/test_node.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:204: test/CMakeFiles/test_node.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
---
Failed   <<< performance_test [14.5s, exited with code 2]

As explained similarly in #134 & #135

[alsora]

Hi, sorry I completely missed these issues.
I included the PRs with the fix.

Thank you for the report