use rclcpp Qos type rather than underlying struct for service creation

[LucienMorey]

I think this change may have been missed in f04d164. Things compile normally with the current debian installations of the rolling distribution on ubuntu. However, Things fail when an installation from source has been used.

[LucienMorey]

Here is the error message for some extra context:

/home/lucien/git/ros2-realtime-image/cache/ros2_x/src/ros2-performance/performance_test/include/performance_test/performance_node_base_impl.hpp:183:68: error: invalid initialization of reference of type ‘const rclcpp::QoS&’ from expression of type ‘const rmw_qos_profile_t’ {aka ‘const rmw_qos_profile_s’}
  183 |   rclcpp::ClientBase::SharedPtr client = rclcpp::create_client<Srv>(
      |                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^
  184 |     m_node_interfaces.base,
      |     ~~~~~~~~~~~~~~~~~~~~~~~
  185 |     m_node_interfaces.graph,
      |     ~~~~~~~~~~~~~~~~~~~~~~~~
  186 |     m_node_interfaces.services,
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~
  187 |     service_name,
      |     ~~~~~~~~~~~~~
  188 |     qos_profile.get_rmw_qos_profile(),
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  189 |     nullptr);
      |     ~~~~~~~~

[alsora]

Thank you!