Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove symbols like '[' and '#' from the headers of the results files #128

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Remove symbols like '[' and '#' from the headers of the results files #128

merged 2 commits into from
Dec 21, 2023

Conversation

jfinken
Copy link
Contributor

@jfinken jfinken commented Dec 19, 2023 •
edited
Loading

Our internal query engine cannot handle symbols in the keys (without escaping them) of the headers of the results files. This PR replaces symbols like % with perc etc.

Before

time[ms]   cpu[%]  arena[KB]       in_use[KB]      mmap[KB]        rss[KB]         vsz[KB]         
0          0       0             0                    0              0              0              
1000           1.9       41844          36078          129292         97260          3396848        
...

After

time_ms        cpu_perc  arena_KB       in_use_KB      mmap_KB        rss_KB         vsz_KB         
0              0         0              0              0              0              0              
1000           1.9       41844          36078          129292         97260          3396848        
...

This PR merges to master. This companion PR merges to mauro/iron-events-executor for Humble and Iron support.

@jfinken jfinken mentioned this pull request Dec 19, 2023
Merged
@alsora
Copy link
Collaborator

alsora commented Dec 19, 2023

PR looks good.
The failure in the CI seems unrelated

alsora
alsora previously approved these changes Dec 19, 2023
View reviewed changes
mauropasse
mauropasse reviewed Dec 20, 2023
View reviewed changes
performance_metrics/src/stat_logger.cpp Outdated
stream_out(csv_out, stream, "freq[hz]", narrow_space);
stream_out(csv_out, stream, "throughput[Kb/s]", wide_space, false);
stream_out(csv_out, stream, "size_b", narrow_space);
stream_out(csv_out, stream, "received_num", wide_space);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd replace received_num with received_msgs (and same with othes that use _num, like late_num -> late_msgs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok cool will do, thanks @mauropasse

@mauropasse mauropasse merged commit d47cfb2 into master Dec 21, 2023
@alsora alsora deleted the jfinken/master-heading-no-symbols branch December 24, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauropasse mauropasse mauropasse approved these changes

@alsora alsora alsora left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfinken @alsora @mauropasse