Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rahul/ifl 2350 add information to cli output to indicate next command to #4828

Conversation

patnir
Copy link
Contributor

@patnir patnir commented Mar 8, 2024

Summary

Adding information to cli output to indicate next step in multi sig signing process.

I leaned on the side of providing less information

Testing Plan

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.

[ ] Yes

@patnir patnir requested a review from a team as a code owner March 8, 2024 22:47
Copy link
Member

@rohanjadvani rohanjadvani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should include the next command the next party should run too. Ex. Send the commitment to the coordinator. They will need to run 'ironfish wallet:multisig:commitment:aggregate'. What do you think?

@patnir
Copy link
Contributor Author

patnir commented Mar 11, 2024

I wonder if we should include the next command the next party should run too. Ex. Send the commitment to the coordinator. They will need to run 'ironfish wallet:multisig:commitment:aggregate'. What do you think?

I thought wanted doing it this way, but I felt like it isn't super relevant to the participant what the coordinator runs next. That information can be found in the docs, I thought of just focusing it to the immediate next step.

@patnir patnir merged commit 117b0c1 into staging Mar 14, 2024
10 checks passed
@patnir patnir deleted the rahul/ifl-2350-add-information-to-cli-output-to-indicate-next-command-to branch March 14, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants