Rahul/ifl 1881 adds transaction progress bar to wallet send #4854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patnir
force-pushed
the
rahul/ifl-1881-transaction-progress-bar-for-wallet-send
branch
3 times, most recently
from
3926c60
to
0713fb3
Compare
patnir
force-pushed
the
rahul/ifl-1881-transaction-progress-bar-for-wallet-send
branch
3 times, most recently
from
453562a
to
862af17
Compare
patnir
changed the title
hughy
approved these changes
Apr 10, 2024
Updates the spend post time at the end of the transaction to create a more accurate estimate over time.
patnir
force-pushed
the
rahul/ifl-1881-transaction-progress-bar-for-wallet-send
branch
from
862af17
to
2ee7323
Compare
patnir
deleted the
rahul/ifl-1881-transaction-progress-bar-for-wallet-send
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
spendPostTimeAtin the internal settings because of the above featuresExample:
Testing Plan
wallet:send- this will show youSending the transaction...without an estimate. The next time you run the command, an estimate will be displayedwallet:sendyou should get time estimated for bothDocumentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.