Always honor the name parameter passed to importAccount
#4906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `importAccount` with an `RpcAccountImport` and a non-undefined `name`, the `name` parameter used to be ignored. This is no longer the case: passing a non-undefined `name` now overrides the name of the `RpcAccountImport`.
andiflabs
added
the
breaking-change-rpc
hughy
approved these changes
Apr 18, 2024
rohanjadvani
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When calling
importAccountwith anRpcAccountImportand a non-undefinedname, thenameparameter used to be ignored. This is no longer the case: passing a non-undefinednamenow overrides the name of theRpcAccountImport.Testing Plan
Unit tests
Documentation
No doc change required because the current doc (https://ironfish.network/developers/documentation/rpc/wallet/import_account) does not specify any limitations for
nameBreaking Change
This is a breaking change because the behavior of calls to
importAccountusingnamehas changed.