Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds chainport transaction summary util #5011

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

patnir
Copy link
Contributor

@patnir patnir commented Jun 5, 2024

Summary

This summary will be used in the wallet:transaction command

Example output (outgoing transaction):

image

Testing Plan

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes

@patnir patnir requested a review from a team as a code owner June 5, 2024 21:52
const transactionStatus = await fetchChainportTransactionStatus(networkId, hash)
CliUx.ux.action.stop()

logger.debug(JSON.stringify(transactionStatus, null, 2))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to keep this in, even with verbose output?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took it out

@patnir patnir merged commit eaef657 into staging Jun 5, 2024
9 checks passed
@patnir patnir deleted the rahul/ifl-2646-chainport-transaction-summary-util branch June 5, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants