Upgrade to oclif 4.x #5130
Merged
Upgrade to oclif 4.x #5130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-if
commented
Jul 11, 2024
| .run() | ||
| .then(require('@oclif/core/flush')) | ||
| .catch(require('@oclif/core/handle')) | ||
| require('@oclif/core').execute({ dir: __dirname }) |
There was a problem hiding this comment.
This change makes me a little nervous, but is the new? default according to the docs. Doing it the way we had was making it throw stack traces for even non-error things which was very strange.
mat-if
commented
Jul 11, 2024
| @@ -19,7 +19,7 @@ export class BannedCommand extends IronfishCommand { | |||
| sort: { | |||
| ...sort, | |||
| exclusive: ['follow'], | |||
| }, | |||
| } as typeof sort, | |||
There was a problem hiding this comment.
:(
I don't know why it started complaining about the type inference here, but here we are. There might some Typescript-ism that does what it wants here without the as keyword, but I don't have any clever ideas right now and this does the job
andiflabs
approved these changes
Jul 11, 2024
It looks like we were using this library which we had because it was being installed as an indirect dependency. That indirect dependency has apparently been removed, which was causing our usage of it to break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The final oclif 4.x upgrade PR
Testing Plan
Documentation
N/A
Breaking Change
N/A