Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix start command wallet flag over-riding config #5204

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Fix start command wallet flag over-riding config #5204

merged 1 commit into from
Aug 2, 2024

Conversation

NullSoldier
Copy link
Contributor

Summary

Because it defaulted to true instead of undefined.

Testing Plan

ironfish config:set enableWallet false
ironfish start
// See that the wallet is still started before the change and not after
ironfish status

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes

@NullSoldier
Fix start command wallet flag over-riding config
113ea68 
Because it defaulted to true instead of undefined.
@NullSoldier NullSoldier requested a review from a team as a code owner August 2, 2024 21:26
@NullSoldier NullSoldier enabled auto-merge (squash) August 2, 2024 21:32
@NullSoldier NullSoldier merged commit c89980c into staging Aug 2, 2024
6 checks passed
@NullSoldier NullSoldier deleted the jason/fix-wallet-flag branch August 2, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-if mat-if mat-if approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NullSoldier @mat-if