Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for "enhance asset" in asset attributes #417

Closed
zkat opened this issue Jul 14, 2024 · 1 comment · Fixed by #459
Closed

Support for "enhance asset" in asset attributes #417

zkat opened this issue Jul 14, 2024 · 1 comment · Fixed by #459
Assignees
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@zkat
Copy link
Member

zkat commented Jul 14, 2024

Some assets, such as Sundered Isles' CREW COMMANDER, have an attribute that, when checked, alters the asset itself. In this case, the COMMAND control goes from 4 max to 6 max.

This might be fairly easy to implement or it might be tricky, depending on how it's done, but I think the easiest way is to just do it right in the asset renderer and do some shenanigans where the asset enhancement gets deep-merged in as-is. I think this will be good enough?

@zkat zkat added feature New feature or request help wanted Extra attention is needed labels Jul 14, 2024
@cwegrzyn
Copy link
Collaborator

Hmm, I think if we put this somewhere in the character asset lens stack we can have a single source of truth where assets have active enhancements applied. Don't forget that we will want this other places too-- like in determining valid values in take/suffer on meter commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants