Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nightly build #149

Closed
wants to merge 1 commit into from
Closed

fix nightly build #149

wants to merge 1 commit into from

Conversation

miller-time
Copy link

@miller-time miller-time commented Aug 9, 2019

closes #148

I guess route-recognizer is no longer maintained? My PR:
http-rs/route-recognizer#25
comment from Alex Crichton:
http-rs/route-recognizer#26 (comment)

@miller-time
Copy link
Author

miller-time commented Aug 9, 2019

Travis CI got this warning+error, and I ran cargo +nightly build locally and got the same thing:

warning: Patch `route-recognizer v0.1.12 (https://github.com/miller-time/route-recognizer.rs?rev=d7bc06d2dc58a2c59d8f2cfbee2ab23b8188700d#d7bc06d2)` was not used in the crate graph.
Check that the patched package version and available features are compatible
with the dependency requirements. If the patch has a different version from
what is locked in the Cargo.lock file, run `cargo update` to use the new
version. This may also occur with an optional dependency that is not enabled.

 error[E0463]: can't find crate for `recognizer`
 --> src/lib.rs:7:1
  |
7 | extern crate route_recognizer as recognizer;
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate

Looks like this isn't actually an option...

@miller-time
Copy link
Author

Well, I read the cargo docs and discovered that I made this change incorrectly. I shouldn't have removed dependencies.route-recognizer when adding patch.crates-io.route-recognizer.

@miller-time miller-time reopened this Aug 9, 2019
@miller-time miller-time changed the title fix nightly build (fixes #148) fix nightly build Aug 9, 2019
closes iron#148

- use patch for route-recognizer
- add `dyn` to trait objects

I guess route-recognizer is no longer maintained? My PR:
http-rs/route-recognizer#25
Comment from Alex Crichton:
http-rs/route-recognizer#26 (comment)
@phlmn
Copy link
Member

phlmn commented Aug 13, 2019

Thanks for the PR!

I just merged iron/iron#591, the router crate now lives inside workspace in the main repo (https://github.com/iron/iron/tree/master/router). Could you move the PR?

@miller-time
Copy link
Author

@phlmn done - iron/iron#614

@phlmn
Copy link
Member

phlmn commented Aug 13, 2019

Thanks! 🙂

@phlmn
Copy link
Member

phlmn commented Aug 13, 2019

Moved to iron/iron#614

@phlmn phlmn closed this Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to build on nightly-2019-08-02
2 participants