Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provision VMs for automated benchmark testing #603

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Provision VMs for automated benchmark testing #603

merged 5 commits into from
Sep 11, 2024

Conversation

byteocean
Copy link
Contributor

New feature to resolve the issue described in #592. The details regarding the provision process can be found in the updated doc.

@github-actions github-actions bot added size/XL documentation Improvements or additions to documentation enhancement New feature or request labels Aug 27, 2024
@byteocean byteocean mentioned this pull request Aug 28, 2024
Open
@byteocean byteocean force-pushed the feature/vm_provision branch 2 times, most recently from 1f21490 to 9c9e1fe Compare September 10, 2024 13:57
@guvenc guvenc marked this pull request as ready for review September 10, 2024 16:35
@guvenc guvenc requested a review from a team as a code owner September 10, 2024 16:35
guvenc
guvenc requested changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@guvenc guvenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tao. This is already in good shape and I was able to run it in my setup with your help. Our findings from the test run are already incorporated to the PR but I have some final comments.

docs/testing/automated_benchmark_test.md Outdated Show resolved Hide resolved
docs/testing/automated_benchmark_test.md Outdated Show resolved Hide resolved
docs/testing/automated_benchmark_test.md Show resolved Hide resolved
@byteocean
Copy link
Contributor Author

Thanks Tao. This is already in good shape and I was able to run it in my setup with your help. Our findings from the test run are already incorporated to the PR but I have some final comments.

Thanks for the feedbacks. The documentation has been updated to be clearer.

@guvenc guvenc merged commit cfcfff7 into main Sep 11, 2024
6 checks passed
@guvenc guvenc deleted the feature/vm_provision branch September 11, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guvenc guvenc guvenc approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byteocean @guvenc