Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipam range create validation #201

Merged
merged 10 commits into from
Dec 21, 2021
Merged

ipam range create validation #201

merged 10 commits into from
Dec 21, 2021

Conversation

GrigoriyMikhalkin
Copy link
Contributor

Solves #198

@GrigoriyMikhalkin
Copy link
Contributor Author

Had to move webhooks into it's own package. Otherwise, controller-gen would fail, because it's trying to treat custom validator as runtime.Object and generate deep copy code for it if it's located in apis package.

@GrigoriyMikhalkin GrigoriyMikhalkin changed the title WIP ipam range create validation ipam range create validation Nov 12, 2021
adracus
adracus suggested changes Nov 16, 2021
View reviewed changes
webhooks/network/ipamrange_webhook.go Outdated Show resolved Hide resolved
webhooks/network/ipamrange_webhook.go Outdated Show resolved Hide resolved
webhooks/network/ipamrange_webhook.go Outdated Show resolved Hide resolved
webhooks/network/ipamrange_webhook.go Outdated Show resolved Hide resolved
@GrigoriyMikhalkin
Copy link
Contributor Author

@adracus Removed custom webhooks and moved all logic back to apis.

adracus
adracus reviewed Nov 18, 2021
View reviewed changes
Copy link
Contributor

@adracus adracus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments, as soon as the children names are reported we should be fine to merge 🎉

apis/network/v1alpha1/ipamrange_webhook.go Outdated Show resolved Hide resolved
apis/network/v1alpha1/ipamrange_webhook.go Show resolved Hide resolved
adracus
adracus suggested changes Nov 23, 2021
View reviewed changes
apis/network/v1alpha1/ipamrange_webhook.go Outdated Show resolved Hide resolved
apis/network/v1alpha1/ipamrange_webhook.go Outdated Show resolved Hide resolved
@adracus adracus merged commit 11975ce into main Dec 21, 2021
@adracus adracus deleted the 198-ipam-webhook branch December 21, 2021 08:37
@afritzler afritzler added the enhancement New feature or request label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adracus adracus adracus approved these changes

Assignees
No one assigned
Labels
api-change enhancement New feature or request network size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GrigoriyMikhalkin @adracus @afritzler