Implement compute validation
#346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
api-change
compute
enhancement
afritzler
force-pushed
the
feature/compute-validation
branch
from
352d483
to
b322cbd
Compare
adracus
suggested changes
Apr 13, 2022
afritzler
force-pushed
the
feature/compute-validation
branch
2 times, most recently
from
433edeb
to
904acd9
Compare
adracus
suggested changes
Apr 13, 2022
afritzler
force-pushed
the
feature/compute-validation
branch
from
904acd9
to
09cd45f
Compare
adracus
approved these changes
Apr 13, 2022
afritzler
force-pushed
the
feature/compute-validation
branch
2 times, most recently
from
72c7d41
to
ba4e6af
Compare
Implement validation for the following `compute` types: - `Machine` - `MachineClass` - `MachinePool` Adjust tests to fit the new validation.
afritzler
force-pushed
the
feature/compute-validation
branch
from
ba4e6af
to
69af236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Implement validation for the following
computetypes:MachineMachineClassMachinePoolAdjust tests to fit the new validation.