Fix Volume binding sporadic
#373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Volume binding used to timeout since for the scheduler, first the `Volume` and then the `VolumeClaim` was updated with the reference of the other member. This commit changes the `Volume.Status.Phase` from a plain `string` type to a `VolumeCondition` of type `VolumeBound`. By doing so, the controller can now check the last time the `VolumeBound` condition transitioned and thus implement a grace period for binding (configurable on the `Volume` controller).
afritzler
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Volume binding used to timeout since for the scheduler, first the
Volumeand then theVolumeClaimwas updated with the reference ofthe other member.
This commit changes the
Volume.Status.Phasefrom a plainstringtypeto a
VolumeConditionof typeVolumeBound. By doing so, thecontroller can now check the last time the
VolumeBoundconditiontransitioned and thus implement a grace period for binding (configurable
on the
Volumecontroller).Fixes #362