Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance tests (use ginkgo/v2) #377

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Enhance tests (use ginkgo/v2) #377

merged 1 commit into from
Apr 27, 2022

Conversation

adracus
Copy link
Contributor

@adracus adracus commented Apr 27, 2022

Proposed Changes

  • Make sure ginkgo/v2 is used everywhere
  • Adapt the test code in a first shot to make use of the new Ginkgo
    capabilities (DeferCleanup, easier global timeouts / thresholds)

@adracus adracus requested a review from afritzler April 27, 2022 08:58
@github-actions github-actions bot added api-change compute documentation Improvements or additions to documentation enhancement New feature or request ipam storage size/L labels Apr 27, 2022
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

* Make sure `ginkgo/v2` is used everywhere
* Adapt the test code in a first shot to make use of the new Ginkgo
  capabilities (`DeferCleanup`, easier global timeouts / thresholds)
@adracus adracus merged commit 7c03f3a into main Apr 27, 2022
@adracus adracus deleted the feature/enhance-tests branch April 27, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change compute documentation Improvements or additions to documentation enhancement New feature or request ipam size/L storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants