Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NetworkProtection controller #462

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Add NetworkProtection controller #462

merged 3 commits into from
Aug 4, 2022

Conversation

afritzler
Copy link
Member

Proposed Changes

The NetworkProtection controller ensures that a finalizer is present on the Network resource as long as it is being referenced/used by resources like NetworkInterfaces or AliasPrefixes.

Fixes #444

@afritzler
Add NetworkProtection controller
f8070d6 
The `NetworkProtection` controller ensures that a finalizer is present
on the `Network` resource as long as it is being referenced/used by resources
like `NetworkInterface`s or `AliasPrefix`es.
@afritzler afritzler requested a review from a team as a code owner August 3, 2022 14:40
@afritzler afritzler added the enhancement New feature or request label Aug 3, 2022
adracus
adracus reviewed Aug 3, 2022
View reviewed changes
Copy link
Contributor

@adracus adracus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double-check with the kubernetes pv-protection controller how caching might affect the removal of the finalizer - do they ever do a live check (w/o cache) agains the kube-apiserver?

controllers/networking/network_protection_controller.go Outdated Show resolved Hide resolved
controllers/networking/network_protection_controller.go Outdated Show resolved Hide resolved
controllers/networking/network_protection_controller.go Show resolved Hide resolved
@afritzler
Copy link
Member Author

Thanks @adracus for the review! Regarding the non cached access: from looking at the pv protection controller there is only one GET for the PV object via the PersistentVolumeLister. Determining if a PV is being used is done just by checking the Phase of the PV - so pretty trivial to what we need to do here.

@afritzler afritzler force-pushed the enh/network-protection-controller branch from 752fc73 to 5a101e2 Compare August 4, 2022 08:44
@afritzler afritzler force-pushed the enh/network-protection-controller branch from 5a101e2 to 94e9d36 Compare August 4, 2022 08:46
@afritzler afritzler merged commit cc69843 into main Aug 4, 2022
@afritzler afritzler deleted the enh/network-protection-controller branch August 4, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adracus adracus adracus approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request networking size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finalizer for the Network object
2 participants
@afritzler @adracus