Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced broker and poollet to support Volume encryption #934

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Enhanced broker and poollet to support Volume encryption #934

merged 2 commits into from
Dec 14, 2023

Conversation

lukasfrank
Copy link
Member

Proposed Changes

  • Added EncryptionData to iri-machine
  • Enhanced Machine-poollet
  • Enhanced Machine-broker

@lukasfrank lukasfrank requested a review from a team as a code owner December 11, 2023 12:12
@github-actions github-actions bot added size/XL enhancement New feature or request labels Dec 11, 2023
@hardikdr hardikdr linked an issue Dec 13, 2023 that may be closed by this pull request
Support Encrypted Ceph Volumes #928
Closed
5 tasks
afritzler
afritzler requested changes Dec 13, 2023
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the encryption secret changes? Don't we also need to change the Watch setup in the poollet manager?

@lukasfrank lukasfrank merged commit 212c5a6 into main Dec 14, 2023
8 checks passed
@lukasfrank lukasfrank deleted the enh/volume-encryption branch December 14, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Encrypted Ceph Volumes
2 participants
@lukasfrank @afritzler