Validate Server discovery failure in an extra test #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until a Server becomes Available it is consistently changing between the Initial and Discovery state. Thus every check against a Servers state after an initial check for Initial and before a sucessfull Available check is racy. The raciness is reduced by validating discovery failure in a dedicated test.
Nuckal777
force-pushed
the
test-validate-discovery-failure
branch
from
4aef311 to
a5db086
Compare
afritzler
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Until a Server becomes Available it is consistently changing between the Initial and Discovery state. Thus every check against a Servers state after an initial check for Initial and before a sucessful Available check is racy. The raciness is reduced by validating discovery failure in a dedicated test.