Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#include does not correctly find files when extension is not .spin2 #11

Closed
2 tasks done
Wuerfel21 opened this issue May 5, 2024 · 2 comments
Closed
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@Wuerfel21
Copy link

and have you...

  • I updated to the latest spin2 version available
  • I have restarted VSCode and the problem still exists

Version of Spin2 Language Server VScode Extension with the issue

eggplant

Is this a regression?

No or unsure. This never worked, or I haven't tried before.

Hardware, Operating System, Operating System version, VSCode version

Hardware: Atari Jaguar
OS Ver: rawr grrr
VSCode Ver: poteto

Description of problem

When using an include file whose filename doesn't have a .spin2 extension, the file is not found and the definitions are not imported.

The log prints something like this

TRC: -- STEP preload any includes not already loaded...
TRC: -- STEP incorporate included docs into maps ...
TRC: [ID:1714949830401-miko68k.spin2] nameHashKeys=[], nameHashValues=[], includedFiles=[p2defs.inc]
TRC: DP.process() hook-in includes for [ID:1714949830401-miko68k.spin2]  objectNames=[]  objectFileNames=[]
TRC: [ID:1714949830401-miko68k.spin2] clear() previous findings but NOT include info so can load included documents
TRC: MATCHING includeFilename=[p2defs.inc], matchFilename=[p2defs.inc.]
TRC: NO include filename matches found!
TRC: DP._parseDocument() clear() previous findings - leaving include info [ID:1714949830401-miko68k.spin2]
TRC: DP._parseDocument() Actual-Parse Spin2 Document: miko68k.spin2

This discovery comes courtesy of the finding that there's a common subset of syntax between Spin2 CON sections and 68000 assembly (lines like NAME = $1234 are valid in both)

Additional information

No response

@Wuerfel21 Wuerfel21 added the bug Something isn't working label May 5, 2024
@ironsheep
Copy link
Owner

Huh... I'll see what this is... and address it.

@ironsheep ironsheep self-assigned this May 8, 2024
ironsheep added a commit that referenced this issue May 9, 2024
ironsheep added a commit that referenced this issue May 10, 2024
- add NOTE that we don't handle #includes yet
@ironsheep
Copy link
Owner

Changes committed will appear in v2.2.17 and later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants