Disable nagle on whois sockets (#218)

This incorporates #194 with a fixed unit test.
irrdnet · Apr 29, 2019 · e033ad4 · e033ad4
1 parent 2c63ffc
commit e033ad4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/irrd/server/whois/protocol.py b/irrd/server/whois/protocol.py
@@ -35,6 +35,9 @@ def connectionMade(self) -> None:  # noqa: N802
             self.transport.loseConnection()
             return
 
+        # disable nagle
+        self.transport.setTcpNoDelay(True)
+
         self.peer_str = f'[{peer.host}]:{peer.port}'
 
         self.query_parser = WhoisQueryParser(peer, self.peer_str)

diff --git a/irrd/server/whois/tests/test_protocol.py b/irrd/server/whois/tests/test_protocol.py
@@ -128,7 +128,8 @@ def test_whois_protocol_access_list_permitted(self, config_override, mock_pipeli
         receiver.factory = mock_factory
 
         receiver.connectionMade()
-        assert len(mock_transport.mock_calls) == 0
+        # with setTcpNoDelay(True) this should be 1
+        assert len(mock_transport.mock_calls) == 1
 
     def test_whois_protocol_access_list_denied(self, config_override):
         config_override({