Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore IRRd v2 / v3 clutter in dump files #232

Closed
job opened this issue Jun 19, 2019 · 4 comments
Closed

Ignore IRRd v2 / v3 clutter in dump files #232

job opened this issue Jun 19, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@job
Copy link
Member

job commented Jun 19, 2019

Describe the bug
IRRd v4 sometimes has trouble loading dumps from older IRRd versions. Older IRRd instances would mark deleted objects with *xx as the first three chars of the object type, which meant that later on down in the file there will be a newer version of that object. This way IRRd wouldn't have to reshuffle its full flat text file database all the time.

To Reproduce
Today's RADB dump can't be loaded:

Error occurred while processing object:
Unknown object class: *xxte

Expected behaviour
The irrd_load_database command should be able to ingest dump files that have IRR objects of object class types such as *xx-num:,*xxner:, *xxset:, *xxte-set:, *xxte6:, or *xxte:), and just ignore those without warning and not error. Just pretend that object didn't exist.

IRRd version you are running
E.g. 4.0.1

Additional context
Add any other context about the problem here.

@mxsasha
Copy link
Collaborator

mxsasha commented Jun 20, 2019

Yes, we can do this, but see my comment #233 as well. As in, I'm not sure why you're loading RADB manually instead of through the regular mirror process.

@job
Copy link
Member Author

job commented Jun 20, 2019

Mirroring had broken for some reason, and the NRTM gap was too large for the source IRRd instance to fill so it wouldn't re-established, so we had to re-seed from RADB's FTP dump which contains these *xx prefix'ed object classes.

I agree with the tending to be strict, but in the case of *xx objects we know what they are and why they are there, we can safely ignore those objects.

@mxsasha
Copy link
Collaborator

mxsasha commented Jun 24, 2019

As https://irrd4.readthedocs.io/en/latest/users/mirroring.html now says:

Unknown object classes that start with *xx are silently ignored, as these are harmless artifacts from certain legacy IRRd versions.

@job
Copy link
Member Author

job commented Jun 26, 2019

this works as advertised!

mxsasha added a commit that referenced this issue Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants