Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS-SET should be able to reference AS-SET in other sources. #240

Closed
troy2914 opened this issue Jun 27, 2019 · 2 comments
Closed

AS-SET should be able to reference AS-SET in other sources. #240

troy2914 opened this issue Jun 27, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@troy2914
Copy link
Member

Attempted in 4.0.2

Modify FAILED: [as-set] AS2914:AS-EUROPE-V6
ERROR: Object AS-1AND1 referenced in field members not found in database NTTCOM - must reference one of aut-num, as-set.
ERROR: Object AS-3W-INFRA referenced in field members not found in database NTTCOM - must reference one of aut-num, as-set.

Actually for that matter, I do not think any checks beyond valid content (ascii and of the form as-set name or asn ) of as-set/asn names, should be checked for the as-set members. E.g. it may refer to as-set's/ASNs that do not currently exist.

@troy2914 troy2914 added the bug Something isn't working label Jun 27, 2019
@mxsasha
Copy link
Collaborator

mxsasha commented Jun 28, 2019

I'll pick this up and validate only on valid ASN or valid as-set name. I take it the same principle should apply to rtr-set and route-set? Those also have the same strong validation now.

@job
Copy link
Member

job commented Jun 28, 2019 via email

mxsasha added a commit that referenced this issue Jun 29, 2019
This adds weak reference support, which means a reference between
RPSL objects is checked for syntax, but not whether the object
exists. This commit enables weak refs for all existing strong
references of members, member-of, mp-members and mbrs-by-ref.
mxsasha added a commit that referenced this issue Jun 29, 2019
Backport of e97798a from master.

This adds weak reference support, which means a reference between
RPSL objects is checked for syntax, but not whether the object
exists. This commit enables weak refs for all existing strong
references of members, member-of, mp-members and mbrs-by-ref.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants