Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

case sensitive inverse queries with 4.4.1 #868

Closed
schelcj opened this issue Oct 13, 2023 · 0 comments
Closed

case sensitive inverse queries with 4.4.1 #868

schelcj opened this issue Oct 13, 2023 · 0 comments

Comments

@schelcj
Copy link
Contributor

schelcj commented Oct 13, 2023

Describe the bug
Seeing case-sensitive inverse query results.

To Reproduce

$ echo '!ias5050:rs-psc-300scrg,1' | nc whois2.radb.net 43
D
$ echo !iAS5050:RS-PSC-300SCRG,1' | nc whois2.radb.net 43
A49
128.182.0.0/16 192.101.139.0/24 192.101.140.0/24
C
$ echo 'as5050:rs-psc-300scrg' | nc whois2.radb.net 43
route-set:      AS5050:RS-PSC-300SCRG
descr:          Routes belonging to PSC, 300SCRG Campus
members:        AS1206
mp-members:     AS1206
tech-c:         FAMWRBSFPO
mnt-by:         MAINT-AS5050
changed:        lambert@psc.edu 20170209
source:         RADB

Expected behaviour
Same prefix lists results regardless of the case of the route-set.

IRRd version you are running
4.4.1

Additional context
Testing against rr.ntt.net running 4.2.8 gives the expected results.
mxsasha added a commit that referenced this issue Oct 17, 2023
@mxsasha
Fix #868 - Fix query case issue in new set resolving
596eae6 
Previously, uppercase conversion was done in the SQL query's rpsl_pks(), but this is no longer used for this query. RPSL PK in the DB is already always in upper case.
mergify bot pushed a commit that referenced this issue Oct 17, 2023
@mxsasha @mergify
Fix #868 - Fix query case issue in new set resolving
be0c158 
Previously, uppercase conversion was done in the SQL query's rpsl_pks(), but this is no longer used for this query. RPSL PK in the DB is already always in upper case.

(cherry picked from commit 4badeee)
mxsasha added a commit that referenced this issue Oct 17, 2023
@mergify @mxsasha
[4.4.x] Fix #868 - Fix query case issue in new set resolving (#870)
bb53c6c 
Previously, uppercase conversion was done in the SQL query's rpsl_pks(), but this is no longer used for this query. RPSL PK in the DB is already always in upper case.

(cherry picked from commit 4badeee)

Co-authored-by: Sasha Romijn <github@mxsasha.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schelcj